Disable failing TCP server test#1311
Merged
Merged
Conversation
|
1389897 to
a8035ae
Compare
sudden6
approved these changes
Mar 9, 2019
sudden6
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
a8035ae to
6a1a828
Compare
Codecov Report
@@ Coverage Diff @@
## master #1311 +/- ##
========================================
- Coverage 84.4% 84.2% -0.3%
========================================
Files 85 85
Lines 15442 15443 +1
========================================
- Hits 13047 13008 -39
- Misses 2395 2435 +40
Continue to review full report at Codecov.
|
The test's intermittent failure may well be exposing a real bug in the TCP relay and/or onion systems, but we can't find the bug, and keeping the test is disrupting our CI.
6a1a828 to
efff822
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test's intermittent failure may well be exposing a real bug in the
TCP relay and/or onion systems, but we can't find the bug, and keeping
the test is disrupting our CI.
This change is