Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add NAT traversal #209
Reviewed 3 of 19 files at r1, 1 of 10 files at r2, 1 of 14 files at r3, 2 of 2 files at r4, 7 of 14 files at r5.
Replace ", hence t" with ". T". It's not really something that follows from the other. Making it two sentences doesn't make this statement weaker.
I can see why you did this, but it doesn't quite fit there. Unknown type is a global error condition and doesn't have anything to do with either upnp or natpmp. I don't know what's the best thing to do here. You could
For the proxy type, we check it in tox.c, for savedata type, we just ignore invalid values. I'll leave it up to you what to do here - just providing some thoughts.
You could make these 4 lines:
This allocation leaks on every call. Since you're not doing any string formatting, you could just return the string literal. Replace all strcpy+breaks with return "message";.
What do you think about making this a bitfield instead of an enum class? It currently is a bitfield by accident:
Note that this is a question, don't change things before discussing.
Comments from Reviewable
@Ansa89 this needs to pass reviewable, and reviewable + github have mangled the comments so bad I can't review this.
Please reopen a new pull request and I'll review that one.
I'm going to leave this open for now to make sure I don't clobber any information.