Skip to content

refactor: Store time in Mono_Time in milliseconds. - #2203

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:mono-time-ms
Nov 18, 2023
Merged

refactor: Store time in Mono_Time in milliseconds.#2203
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:mono-time-ms

Conversation

@iphydf

@iphydf iphydf commented Mar 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Conversion to seconds happens in mono_time_get, and a new function
mono_time_get_ms allows code to retrieve monotonic time in
milliseconds.

This change is Reviewable

@iphydf iphydf added this to the v0.2.18 milestone Mar 28, 2022
@auto-add-label auto-add-label Bot added the refactor Refactoring production code, eg. renaming a variable, not affecting semantics label Mar 28, 2022
@iphydf
iphydf force-pushed the mono-time-ms branch 6 times, most recently from 5d1c5d2 to 61715e5 Compare April 4, 2022 13:46
@iphydf
iphydf force-pushed the mono-time-ms branch 2 times, most recently from 09f510a to 7ae51ec Compare April 7, 2022 20:34
@iphydf iphydf modified the milestones: v0.2.18, v0.2.19 Apr 7, 2022
@iphydf iphydf modified the milestones: v0.2.19, v0.2.20 Apr 18, 2022
@codecov

codecov Bot commented Nov 10, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8235d9b) 74.49% compared to head (a974898) 74.58%.
Report is 1 commits behind head on master.

❗ Current head a974898 differs from pull request most recent head e726b19. Consider uploading reports for the commit e726b19 to get more accurate results

Files Patch % Lines
toxcore/group_chats.c 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2203      +/-   ##
==========================================
+ Coverage   74.49%   74.58%   +0.08%     
==========================================
  Files          87       87              
  Lines       26243    26244       +1     
==========================================
+ Hits        19551    19573      +22     
+ Misses       6692     6671      -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Green-Sky
Green-Sky reviewed Nov 10, 2023
View reviewed changes

@Green-Sky Green-Sky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 1 approvals obtained

Green-Sky
Green-Sky approved these changes Nov 10, 2023
View reviewed changes

@Green-Sky Green-Sky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@iphydf
refactor: Store time in Mono_Time in milliseconds.
e726b19 
Conversion to seconds happens in `mono_time_get`, and a new function
`mono_time_get_ms` allows code to retrieve monotonic time in
milliseconds.
JFreegman
JFreegman approved these changes Nov 17, 2023
View reviewed changes

@JFreegman JFreegman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained

@iphydf
iphydf merged commit e726b19 into TokTok:master Nov 18, 2023
@iphydf
iphydf deleted the mono-time-ms branch November 18, 2023 03:43
@iphydf iphydf modified the milestones: v0.2.20, v0.2.19 Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JFreegman JFreegman JFreegman approved these changes
@Green-Sky Green-Sky Green-Sky approved these changes

Assignees

@iphydf iphydf

Labels

refactor Refactoring production code, eg. renaming a variable, not affecting semantics

Milestone

v0.2.19

Development

Successfully merging this pull request may close these issues.

3 participants

@iphydf @JFreegman @Green-Sky