cleanup: make it more clear that assert and uint32_t increment both only exist if NDEBUG is not defined - #2311
Merged
Conversation
iphydf
approved these changes
Apr 26, 2022
iphydf
force-pushed
the
zoff99/ndebug_and_assert
branch
from
November 10, 2023 04:04
408b3a6 to
0fe3af7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2311 +/- ##
==========================================
- Coverage 74.47% 74.46% -0.02%
==========================================
Files 87 87
Lines 26189 26211 +22
==========================================
+ Hits 19505 19517 +12
- Misses 6684 6694 +10
☔ View full report in Codecov by Sentry. |
…nly exist if NDEBUG is not defined
iphydf
force-pushed
the
zoff99/ndebug_and_assert
branch
from
November 12, 2023 06:18
0fe3af7 to
d01c116
Compare
iphydf
reviewed
Nov 12, 2023
iphydf
left a comment
Member
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is