fix: missing net to host conversion of port in logging#2339
Merged
Conversation
auto-add-label
Bot
added
the
bug
Green-Sky
force-pushed
the
net_logger_endianness
branch
from
e732798 to
8054854
Compare
JFreegman
approved these changes
Oct 1, 2022
Member
JFreegman
left a comment
JFreegman
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
Codecov Report
@@ Coverage Diff @@
## master #2339 +/- ##
==========================================
- Coverage 78.15% 78.12% -0.03%
==========================================
Files 140 140
Lines 31045 31045
==========================================
- Hits 24264 24255 -9
- Misses 6781 6790 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is