fix: missing net to host conversion of port in logging in group_chat.c#2340
Merged
Conversation
auto-add-label
Bot
added
the
bug
Green-Sky
force-pushed
the
net_logger_endianness2
branch
from
8c680cf to
a974d89
Compare
Green-Sky
force-pushed
the
net_logger_endianness2
branch
from
a974d89 to
7dfa935
Compare
Codecov Report
@@ Coverage Diff @@
## master #2340 +/- ##
==========================================
- Coverage 78.15% 78.06% -0.09%
==========================================
Files 140 140
Lines 31053 31053
==========================================
- Hits 24268 24243 -25
- Misses 6785 6810 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JFreegman
approved these changes
Oct 4, 2022
JFreegman
left a comment
JFreegman
left a comment
Member
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found some more. i hope those are the last ones.
This change is