fix: #1144 by forcing misc_tools to be a static lib#2341
Merged
sudden6 merged 1 commit intoTokTok:masterfrom Dec 8, 2022
Merged
fix: #1144 by forcing misc_tools to be a static lib#2341sudden6 merged 1 commit intoTokTok:masterfrom
sudden6 merged 1 commit intoTokTok:masterfrom
Conversation
auto-add-label
bot
added
the
bug
Green-Sky
force-pushed
the
fix_misc_tools_extra_so_on_dyn_builds
branch
from
39f5c24 to
2187893
Compare
sudden6
approved these changes
Dec 8, 2022
sudden6
left a comment
sudden6
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
Green-Sky
force-pushed
the
fix_misc_tools_extra_so_on_dyn_builds
branch
from
2187893 to
e1c38b4
Compare
Codecov Report
@@ Coverage Diff @@
## master #2341 +/- ##
=========================================
- Coverage 9.95% 9.94% -0.02%
=========================================
Files 141 141
Lines 32503 32503
=========================================
- Hits 3236 3232 -4
- Misses 29267 29271 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not sure if this works as intended, but i saw a .patch file in the fedora pkg source and was displeased.
an alternative would be to use a cmake OBJECT library.
This change is