fix: Increase max group message length by four bytes#2351
Merged
Conversation
JFreegman
added
bug
JFreegman
force-pushed
the
ngc_max_messge_length
branch
from
679598d to
e8144a2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2351 +/- ##
=========================================
- Coverage 9.94% 9.93% -0.02%
=========================================
Files 141 141
Lines 32503 32503
=========================================
- Hits 3234 3229 -5
- Misses 29269 29274 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
will this actually work? if you send a message with that new maximum size sending will fail, since GC_MESSAGE_PSEUDO_ID_SIZE bytes will be added. |
Member
Author
Why would it fail? |
robinlinden
approved these changes
Mar 3, 2023
JFreegman
force-pushed
the
ngc_max_messge_length
branch
from
e8144a2 to
b2ca401
Compare
JFreegman
force-pushed
the
ngc_max_messge_length
branch
4 times, most recently
from
c66e937 to
c0002cc
Compare
The max message length was reduced by 4 bytes to account for the pseudo message ID, which had unintended effects on clients. It makes more sense to increase the raw packet length by four and keep the max group message length the same as the max message length for friend chats.
JFreegman
force-pushed
the
ngc_max_messge_length
branch
from
c0002cc to
172f279
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The max message length was reduced by 4 bytes to account for the pseudo message ID, which had unintended effects on clients. It makes more sense to increase the raw packet length by four and keep the max group message length the same as the max message length for friend chats.
This change is