refactor: Make event dispatch ordered by receive time.#2392
Merged
Conversation
iphydf
force-pushed
the
ordered-events
branch
2 times, most recently
from
8e372bc to
07f91b7
Compare
Member
|
|
iphydf
force-pushed
the
ordered-events
branch
6 times, most recently
from
919e79b to
beb0ef9
Compare
iphydf
changed the title
iphydf
force-pushed
the
ordered-events
branch
6 times, most recently
from
2436d0d to
c928ff7
Compare
iphydf
force-pushed
the
ordered-events
branch
from
c928ff7 to
2898df7
Compare
iphydf
force-pushed
the
ordered-events
branch
from
2898df7 to
12bed5c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2392 +/- ##
==========================================
- Coverage 71.11% 66.78% -4.34%
==========================================
Files 127 146 +19
Lines 28517 30279 +1762
==========================================
- Hits 20280 20221 -59
- Misses 8237 10058 +1821 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
ordered-events
branch
from
12bed5c to
0834f37
Compare
iphydf
force-pushed
the
ordered-events
branch
from
0834f37 to
1f9ea2f
Compare
iphydf
force-pushed
the
ordered-events
branch
3 times, most recently
from
ae9a535 to
a230308
Compare
iphydf
force-pushed
the
ordered-events
branch
from
a230308 to
bff4d69
Compare
iphydf
force-pushed
the
ordered-events
branch
4 times, most recently
from
7fcb96b to
2949e45
Compare
iphydf
force-pushed
the
ordered-events
branch
from
2949e45 to
b9d15ec
Compare
Closed
iphydf
force-pushed
the
ordered-events
branch
4 times, most recently
from
8052d22 to
a589366
Compare
iphydf
force-pushed
the
ordered-events
branch
12 times, most recently
from
9681dc9 to
db7ce08
Compare
Green-Sky
approved these changes
Jan 11, 2024
iphydf
force-pushed
the
ordered-events
branch
2 times, most recently
from
60a42a0 to
17a9865
Compare
These are quite expensive, because they go through all events to index in a typed array that no longer exists. Clients should index in the union array and find the event they want themselves, or use dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is