Skip to content

cleanup: Enforce stricter identifier naming using clang-tidy.#2404

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:identifier-naming
Sep 1, 2023
Merged

cleanup: Enforce stricter identifier naming using clang-tidy.#2404
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:identifier-naming

Conversation

@iphydf
Copy link
Copy Markdown
Member

@iphydf iphydf commented Aug 31, 2023

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Aug 31, 2023
@iphydf iphydf force-pushed the identifier-naming branch from 2d3ee43 to caf6ef0 Compare August 31, 2023 11:16
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 31, 2023

Codecov Report

Patch coverage: 90.78% and project coverage change: +0.08% 🎉

Comparison is base (a549807) 74.49% compared to head (4d3c97f) 74.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2404      +/-   ##
==========================================
+ Coverage   74.49%   74.57%   +0.08%     
==========================================
  Files          87       87              
  Lines       26194    26194              
==========================================
+ Hits        19512    19533      +21     
+ Misses       6682     6661      -21     
Files Changed Coverage Δ
toxcore/TCP_connection.c 70.86% <71.42%> (ø)
toxcore/network.c 86.09% <84.61%> (ø)
toxcore/TCP_server.c 78.59% <86.95%> (-0.18%) ⬇️
toxcore/TCP_client.c 83.88% <97.05%> (+0.66%) ⬆️
toxcore/DHT.c 84.72% <100.00%> (+0.21%) ⬆️
toxcore/Messenger.c 82.67% <100.00%> (ø)
toxcore/TCP_common.c 78.72% <100.00%> (ø)
toxcore/friend_connection.c 85.77% <100.00%> (+0.22%) ⬆️
toxcore/group_chats.c 70.15% <100.00%> (+0.29%) ⬆️
toxcore/onion_client.c 90.31% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the identifier-naming branch from caf6ef0 to 41675e6 Compare August 31, 2023 11:50
@iphydf iphydf marked this pull request as ready for review August 31, 2023 11:50
Comment thread .circleci/config.yml Outdated
@iphydf iphydf force-pushed the identifier-naming branch from 41675e6 to 4d3c97f Compare August 31, 2023 13:37
@pull-request-attention pull-request-attention Bot assigned Green-Sky and unassigned iphydf Aug 31, 2023
@pull-request-attention pull-request-attention Bot assigned iphydf and unassigned Green-Sky Sep 1, 2023
@iphydf iphydf merged commit 4d3c97f into TokTok:master Sep 1, 2023
@iphydf iphydf deleted the identifier-naming branch September 1, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants