Skip to content

cleanup: Fix GCC compatibility.#2413

Merged
iphydf merged 1 commit intoTokTok:masterfrom
iphydf:gcc-compat
Nov 7, 2023
Merged

cleanup: Fix GCC compatibility.#2413
iphydf merged 1 commit intoTokTok:masterfrom
iphydf:gcc-compat

Conversation

@iphydf
Copy link
Copy Markdown
Member

@iphydf iphydf commented Oct 14, 2023

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Oct 14, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24b5472) 74.43% compared to head (e316d56) 74.45%.

❗ Current head e316d56 differs from pull request most recent head 82276ef. Consider uploading reports for the commit 82276ef to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2413      +/-   ##
==========================================
+ Coverage   74.43%   74.45%   +0.01%     
==========================================
  Files          87       87              
  Lines       26192    26189       -3     
==========================================
+ Hits        19495    19498       +3     
+ Misses       6697     6691       -6     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread testing/fuzzing/fuzz_support.cc
@iphydf iphydf force-pushed the gcc-compat branch 2 times, most recently from cd79f3c to 1923764 Compare November 7, 2023 11:26
Copy link
Copy Markdown
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @iphydf)

@pull-request-attention pull-request-attention bot assigned Green-Sky and unassigned iphydf Nov 7, 2023
@iphydf iphydf merged commit 82276ef into TokTok:master Nov 7, 2023
@iphydf iphydf deleted the gcc-compat branch November 7, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants