Repository navigation
refactor: Add a bin_unpack_bin_max for max-length arrays. - #2415
Merged
Merged
Conversation
iphydf
marked this pull request as draft
November 7, 2023 17:54
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2415 +/- ##
==========================================
+ Coverage 74.47% 74.51% +0.03%
==========================================
Files 87 87
Lines 26189 26211 +22
==========================================
+ Hits 19505 19530 +25
+ Misses 6684 6681 -3
☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
bin-unpack-max
branch
5 times, most recently
from
November 11, 2023 04:30
1624044 to
4af8f08
Compare
iphydf
marked this pull request as ready for review
November 11, 2023 04:30
iphydf
force-pushed
the
bin-unpack-max
branch
3 times, most recently
from
November 11, 2023 04:47
5ab3972 to
ee05a1d
Compare
iphydf
force-pushed
the
bin-unpack-max
branch
2 times, most recently
from
November 12, 2023 00:55
3b9e9f4 to
f755fcc
Compare
These are statically allocated (e.g. `uint8_t[1024]`) arrays with variable length data inside them. Examples are group topics and nicknames.
iphydf
force-pushed
the
bin-unpack-max
branch
from
November 12, 2023 00:57
f755fcc to
58fac53
Compare
JFreegman
approved these changes
Nov 12, 2023
JFreegman
left a comment
JFreegman
left a comment
Member
There was a problem hiding this comment.
Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are statically allocated (e.g.
uint8_t[1024]) arrays with variable length data inside them. Examples are group topics and nicknames.This change is