Skip to content

cleanup: Use tcc docker image for CI.#2427

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:tcc-docker
Nov 18, 2023
Merged

cleanup: Use tcc docker image for CI.#2427
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:tcc-docker

Conversation

@iphydf

@iphydf iphydf commented Nov 18, 2023

Copy link
Copy Markdown
Member

Instead of repeating the instructions in github actions configs.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Nov 18, 2023
@iphydf iphydf requested a review from a team as a code owner November 18, 2023 03:32

@JFreegman JFreegman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@codecov

codecov Bot commented Nov 18, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9095eb) 74.43% compared to head (41e6ea8) 74.53%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2427      +/-   ##
==========================================
+ Coverage   74.43%   74.53%   +0.09%     
==========================================
  Files          87       87              
  Lines       26243    26244       +1     
==========================================
+ Hits        19535    19560      +25     
+ Misses       6708     6684      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Instead of repeating the instructions in github actions configs.
@iphydf iphydf merged commit 41e6ea8 into TokTok:master Nov 18, 2023
@iphydf iphydf deleted the tcc-docker branch November 18, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants