Skip to content

chore: Add a compcert docker run script. - #2428

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:compcert-docker
Nov 18, 2023
Merged

chore: Add a compcert docker run script.#2428
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:compcert-docker

Conversation

@iphydf

@iphydf iphydf commented Nov 18, 2023

Copy link
Copy Markdown
Member

Useful for local runs. Does the same as CI, so if it fails on CI, this can be used to test locally, avoiding slow CI round trips.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Nov 18, 2023
@iphydf
iphydf requested a review from a team as a code owner November 18, 2023 05:47
@codecov

codecov Bot commented Nov 18, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41e6ea8) 74.53% compared to head (6c35cef) 74.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2428      +/-   ##
==========================================
- Coverage   74.53%   74.51%   -0.02%     
==========================================
  Files          87       87              
  Lines       26244    26244              
==========================================
- Hits        19560    19556       -4     
- Misses       6684     6688       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Useful for local runs. Does the same as CI, so if it fails on CI, this
can be used to test locally, avoiding slow CI round trips.

@JFreegman JFreegman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@nurupo nurupo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained

@iphydf
iphydf merged commit 6c35cef into TokTok:master Nov 18, 2023
@iphydf
iphydf deleted the compcert-docker branch November 18, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants