chore: Retry freebsd tests 2 times.#2430
Merged
iphydf merged 3 commits intoTokTok:masterfrom Nov 22, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2430 +/- ##
==========================================
+ Coverage 74.41% 74.43% +0.01%
==========================================
Files 87 87
Lines 26244 26255 +11
==========================================
+ Hits 19530 19542 +12
+ Misses 6714 6713 -1 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
freebsd-tests
branch
from
ebe78ce to
48e28b4
Compare
iphydf
force-pushed
the
freebsd-tests
branch
from
48e28b4 to
c3b1b60
Compare
iphydf
changed the title
iphydf
force-pushed
the
freebsd-tests
branch
2 times, most recently
from
6b2a837 to
ce73b17
Compare
Member
|
Maybe put |
Also, use `cmake --build` instead of manually calling `gmake`. This allows us to maybe later use `ninja` instead of `gmake` without changing this build invocation. Also, increase timeout to 120 seconds. FreeBSD tests are slow.
Both in C and C++, because the C++ tests don't currently run on FreeBSD, and we want to know how the FreeBSD VM performs (answer: poorly).
iphydf
force-pushed
the
freebsd-tests
branch
from
ce73b17 to
a927183
Compare
Member
Author
Done. |
JFreegman
approved these changes
Nov 22, 2023
Member
JFreegman
left a comment
JFreegman
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 3 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
iphydf
force-pushed
the
freebsd-tests
branch
from
90d08dc to
83efb17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, use
cmake --buildinstead of manually callinggmake. This allows us to maybe later useninjainstead ofgmakewithout changing this build invocation.This change is