Skip to content

chore: Use C99 on MSVC instead of C11.#2432

Merged
iphydf merged 1 commit intoTokTok:masterfrom
iphydf:msvc99
Nov 22, 2023
Merged

chore: Use C99 on MSVC instead of C11.#2432
iphydf merged 1 commit intoTokTok:masterfrom
iphydf:msvc99

Conversation

@iphydf
Copy link
Copy Markdown
Member

@iphydf iphydf commented Nov 22, 2023

The windows sdk has buggy headers in C11.


This change is Reviewable

The windows sdk has buggy headers in C11.
@iphydf iphydf added this to the v0.2.19 milestone Nov 22, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7155f7f) 74.47% compared to head (47e77d1) 74.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2432      +/-   ##
==========================================
- Coverage   74.47%   74.41%   -0.06%     
==========================================
  Files          87       87              
  Lines       26244    26244              
==========================================
- Hits        19545    19530      -15     
- Misses       6699     6714      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf marked this pull request as ready for review November 22, 2023 20:26
Copy link
Copy Markdown
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@iphydf iphydf merged commit 47e77d1 into TokTok:master Nov 22, 2023
@iphydf iphydf deleted the msvc99 branch November 22, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants