Skip to content

chore: Upgrade sonar-scan jvm to java 17.#2437

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:sonar-java-17
Nov 23, 2023
Merged

chore: Upgrade sonar-scan jvm to java 17.#2437
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:sonar-java-17

Conversation

@iphydf
Copy link
Copy Markdown
Member

@iphydf iphydf commented Nov 23, 2023

@iphydf iphydf added this to the v0.2.19 milestone Nov 23, 2023
@iphydf iphydf marked this pull request as ready for review November 23, 2023 11:05
@iphydf iphydf requested a review from a team as a code owner November 23, 2023 11:05
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1e850c) 74.45% compared to head (d390947) 74.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2437      +/-   ##
==========================================
- Coverage   74.45%   74.42%   -0.04%     
==========================================
  Files          87       87              
  Lines       26255    26255              
==========================================
- Hits        19549    19541       -8     
- Misses       6706     6714       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@iphydf iphydf merged commit d390947 into TokTok:master Nov 23, 2023
@iphydf iphydf deleted the sonar-java-17 branch November 23, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants