test: Make esp32 build actually try to instantiate tox. - #2439
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2439 +/- ##
==========================================
+ Coverage 69.95% 69.98% +0.02%
==========================================
Files 75 75
Lines 25964 25964
==========================================
+ Hits 18164 18171 +7
+ Misses 7800 7793 -7 ☔ View full report in Codecov by Sentry. |
iphydf
marked this pull request as draft
November 29, 2023 19:50
iphydf
force-pushed
the
esp32
branch
11 times, most recently
from
December 1, 2023 15:45
e38d2a2 to
01d5f15
Compare
iphydf
force-pushed
the
esp32
branch
5 times, most recently
from
December 1, 2023 17:57
a518e73 to
3ec5117
Compare
iphydf
marked this pull request as ready for review
December 1, 2023 17:57
iphydf
force-pushed
the
esp32
branch
4 times, most recently
from
December 9, 2023 11:58
763deda to
9a247dd
Compare
iphydf
force-pushed
the
esp32
branch
2 times, most recently
from
December 19, 2023 18:29
2628446 to
942bd1c
Compare
Green-Sky
reviewed
Dec 19, 2023
Green-Sky
approved these changes
Dec 19, 2023
It doesn't work, because esp32 has too little RAM (320KB). DHT is a 240KB struct, so even just allocating that immediately fails. We'll need to think carefully about trimming that if we ever want this to work on embedded devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It works properly now, but needs external RAM of 4MiB.
This change is