feat: group connection queries now return our own connection type#2448
Merged
Merged
Conversation
JFreegman
added
the
enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2448 +/- ##
==========================================
- Coverage 74.38% 74.35% -0.04%
==========================================
Files 87 87
Lines 26255 26255
==========================================
- Hits 19531 19522 -9
- Misses 6724 6733 +9 ☔ View full report in Codecov by Sentry. |
Green-Sky
requested changes
Dec 4, 2023
JFreegman
force-pushed
the
group_self_connection_status
branch
2 times, most recently
from
cb88ac0 to
f647bf2
Compare
JFreegman
force-pushed
the
group_self_connection_status
branch
from
f647bf2 to
84ba154
Compare
Green-Sky
approved these changes
Dec 4, 2023
Green-Sky
left a comment
Green-Sky
left a comment
Member
There was a problem hiding this comment.
but not a fan of the magic numbers for the state/cap
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @JFreegman)
Member
Author
I wouldn't be against using an enum. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is