Skip to content

cleanup: replace tabs with spaces#2449

Merged
nurupo merged 1 commit into
TokTok:masterfrom
nurupo:spaces-not-tabs
Dec 4, 2023
Merged

cleanup: replace tabs with spaces#2449
nurupo merged 1 commit into
TokTok:masterfrom
nurupo:spaces-not-tabs

Conversation

@nurupo

@nurupo nurupo commented Dec 3, 2023

Copy link
Copy Markdown
Member
c-toxcore$ grep -Ps --line-number '\t' * -R | grep '\.[c|h]:[0-9]\+'
other/bootstrap_daemon/src/tox-bootstrapd.c:457:                kill_gca(group_announce);
toxcore/Messenger.c:2027:       set_friend_status(m, i, FRIEND_CONFIRMED, userdata);
toxcore/Messenger.c:2406:           case PACKET_ID_INVITE_GROUPCHAT:
toxcore/Messenger.c:2407:               return m_handle_packet_invite_groupchat(m, i, data, data_length, userdata);

@Green-Sky (d3819b2) and @JFreegman (0a277b5) have been charged with the heinous crime of tab-berdashery -- the unlawful act of indentation injustice that has left the codebase in a state of uneven spacing disbelief, causing unsuspecting developers to question the very fabric of code aesthetics. Authorities recommend a strict sentence of space-indentation rehabilitation by having to code-review the correctional action of tabs being replaced by spaces.


This change is Reviewable

@nurupo nurupo added this to the v0.2.19 milestone Dec 3, 2023
@nurupo nurupo requested review from Green-Sky and JFreegman December 3, 2023 10:00
@codecov

codecov Bot commented Dec 3, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1b6dee7) 74.38% compared to head (a4df286) 74.38%.

Files Patch % Lines
toxcore/Messenger.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2449   +/-   ##
=======================================
  Coverage   74.38%   74.38%           
=======================================
  Files          87       87           
  Lines       26255    26255           
=======================================
+ Hits        19529    19531    +2     
+ Misses       6726     6724    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Green-Sky Green-Sky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@pull-request-attention pull-request-attention Bot assigned nurupo and unassigned Green-Sky Dec 3, 2023
@nurupo

nurupo commented Dec 3, 2023

Copy link
Copy Markdown
Member Author

Waiting on @JFreegman to approve the review too :D

@JFreegman JFreegman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@nurupo nurupo merged commit a4df286 into TokTok:master Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants