Skip to content

fix: memory leaks - #2454

Merged
nurupo merged 4 commits into
TokTok:masterfrom
nurupo:fix-memory-leaks
Dec 8, 2023
Merged

fix: memory leaks#2454
nurupo merged 4 commits into
TokTok:masterfrom
nurupo:fix-memory-leaks

Conversation

@nurupo

@nurupo nurupo commented Dec 6, 2023

Copy link
Copy Markdown
Member

This change is Reviewable

@nurupo nurupo added this to the v0.2.19 milestone Dec 6, 2023
@nurupo nurupo changed the title Fix memory leaks fix: memory leaks Dec 6, 2023
@codecov

codecov Bot commented Dec 6, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7a6d50e) 74.39% compared to head (4d1db21) 74.48%.

Files Patch % Lines
toxcore/group_connection.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2454      +/-   ##
==========================================
+ Coverage   74.39%   74.48%   +0.09%     
==========================================
  Files          87       87              
  Lines       26264    26265       +1     
==========================================
+ Hits        19538    19563      +25     
+ Misses       6726     6702      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nurupo
nurupo marked this pull request as ready for review December 6, 2023 11:13
@nurupo
nurupo requested a review from JFreegman December 6, 2023 11:13

@JFreegman JFreegman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Comment thread toxcore/group_connection.c Outdated
@pull-request-attention pull-request-attention Bot assigned iphydf and unassigned nurupo Dec 8, 2023
@nurupo
nurupo merged commit 4d1db21 into TokTok:master Dec 8, 2023
@pull-request-attention pull-request-attention Bot assigned nurupo and iphydf and unassigned iphydf and nurupo Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants