Skip to content

cleanup: Remove test net support.#2474

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:no-test-net
Dec 19, 2023
Merged

cleanup: Remove test net support.#2474
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:no-test-net

Conversation

@iphydf

@iphydf iphydf commented Dec 18, 2023

Copy link
Copy Markdown
Member

Mainnet now supports NGC.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Dec 18, 2023
@JFreegman

Copy link
Copy Markdown
Member

Are we never going to need this again?

@iphydf

iphydf commented Dec 18, 2023

Copy link
Copy Markdown
Member Author

Are we never going to need this again?

Maybe we'll need something like this again, but we can add it back (in a different way) at that point. Right now it's a maintenance burden, every time having to read the correct enum when looking at packets during debugging.

@Green-Sky

Copy link
Copy Markdown
Member

Should we allow different networks entirely? I think some dht networks use a simple passphrase.

@iphydf iphydf marked this pull request as ready for review December 18, 2023 21:43
@iphydf

iphydf commented Dec 19, 2023

Copy link
Copy Markdown
Member Author

Should we allow different networks entirely? I think some dht networks use a simple passphrase.

Yes, I think that's a good idea. I think it can be done in a backwards compatible way (accepting both with and without network id).

@codecov

codecov Bot commented Dec 19, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b0dc0f) 69.81% compared to head (65d09c9) 69.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2474      +/-   ##
==========================================
+ Coverage   69.81%   69.95%   +0.14%     
==========================================
  Files          75       75              
  Lines       25964    25964              
==========================================
+ Hits        18127    18164      +37     
+ Misses       7837     7800      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread configure.ac Outdated
@pull-request-attention pull-request-attention Bot assigned iphydf and unassigned Green-Sky Dec 19, 2023
Mainnet now supports NGC.
@iphydf iphydf merged commit 65d09c9 into TokTok:master Dec 19, 2023
@iphydf iphydf deleted the no-test-net branch December 19, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants