Merged
Conversation
b16bd4f to
dbf6c6c
Compare
Member
Author
|
On a different setup/repo, I am getting mostly binaries that assert like this: |
Member
Author
|
looks like non of the cmake based compiles run the unit tests, probably because they cant fine gtest. |
Member
Author
|
tomato-windows-msvc-x86_64(51)-good-master-debug-bad-ithink-test-only.zip |
iphydf
approved these changes
Dec 19, 2023
dbf6c6c to
0c998a7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2477 +/- ##
==========================================
+ Coverage 71.55% 71.58% +0.02%
==========================================
Files 75 75
Lines 25200 25291 +91
==========================================
+ Hits 18033 18105 +72
- Misses 7167 7186 +19 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am having troubles with the windows builds making mono_time a random number generator.
This change is