Skip to content

feat: Add to_string functions for all public enums.#2479

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:enum-to-string
Dec 19, 2023
Merged

feat: Add to_string functions for all public enums.#2479
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:enum-to-string

Conversation

@iphydf

@iphydf iphydf commented Dec 19, 2023

Copy link
Copy Markdown
Member

Generated by tokstyle: TokTok/hs-tokstyle#214


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Dec 19, 2023
@iphydf iphydf marked this pull request as ready for review December 19, 2023 15:38

@JFreegman JFreegman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@codecov

codecov Bot commented Dec 19, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 534 lines in your changes are missing coverage. Please review.

Comparison is base (0c998a7) 71.58% compared to head (5f863a5) 70.02%.

Files Patch % Lines
toxcore/tox_api.c 0.00% 534 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2479      +/-   ##
==========================================
- Coverage   71.58%   70.02%   -1.57%     
==========================================
  Files          75       75              
  Lines       25291    25825     +534     
==========================================
- Hits        18105    18083      -22     
- Misses       7186     7742     +556     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf merged commit 5f863a5 into TokTok:master Dec 19, 2023
@iphydf iphydf deleted the enum-to-string branch December 19, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants