Skip to content

refactor: event generation tool for reorder pr#2485

Merged
Green-Sky merged 2 commits into
TokTok:masterfrom
Green-Sky:tool_for_reorder_pr
Dec 20, 2023
Merged

refactor: event generation tool for reorder pr#2485
Green-Sky merged 2 commits into
TokTok:masterfrom
Green-Sky:tool_for_reorder_pr

Conversation

@Green-Sky

@Green-Sky Green-Sky commented Dec 20, 2023

Copy link
Copy Markdown
Member

supersedes #2482, when #2392 is merged


This change is Reviewable

@codecov

codecov Bot commented Dec 20, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e603bb) 69.90% compared to head (22cd38a) 69.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2485      +/-   ##
==========================================
- Coverage   69.90%   69.82%   -0.08%     
==========================================
  Files          75       75              
  Lines       25999    25999              
==========================================
- Hits        18174    18155      -19     
- Misses       7825     7844      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf added this to the v0.2.19 milestone Dec 20, 2023
@Green-Sky Green-Sky marked this pull request as ready for review December 20, 2023 09:49
Comment thread other/event_tooling/generate_event_c.cpp Outdated
@Green-Sky Green-Sky merged commit 22cd38a into TokTok:master Dec 20, 2023
@Green-Sky Green-Sky deleted the tool_for_reorder_pr branch December 23, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants