cleanup: Remove NaCl support. - #2497
Merged
Merged
Conversation
iphydf
force-pushed
the
rm-nacl
branch
2 times, most recently
from
December 25, 2023 00:35
1e6ea60 to
e126749
Compare
iphydf
marked this pull request as ready for review
December 25, 2023 00:35
We now depend on libsodium unconditionally. Future work will require functions from libsodium, and nobody we're aware of uses the nacl build for anything other than making sure it still works on CI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2497 +/- ##
==========================================
+ Coverage 68.98% 69.01% +0.02%
==========================================
Files 89 89
Lines 27770 27770
==========================================
+ Hits 19158 19166 +8
+ Misses 8612 8604 -8 ☔ View full report in Codecov by Sentry. |
nurupo
reviewed
Dec 25, 2023
nurupo
approved these changes
Dec 25, 2023
nurupo
left a comment
nurupo
left a comment
Member
There was a problem hiding this comment.
The trailing white space changes in docs/* are a bit unnecessary,especially since not all docs/* got this treatment, but otherwise this PR looks good.
Member
|
Oh, it gets automatically merged, huh. Kind of wanted for @iphydf to decide if he wants to undo those trailing white space changes or not, but I guess this works too, I didn't feel too strongly about it to block the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now depend on libsodium unconditionally. Future work will require functions from libsodium, and nobody we're aware of uses the nacl build for anything other than making sure it still works on CI.
This change is