Skip to content

chore: Simplify msvc build using vcpkg.#2498

Merged
iphydf merged 1 commit into
masterfrom
msvc
Jan 6, 2024
Merged

chore: Simplify msvc build using vcpkg.#2498
iphydf merged 1 commit into
masterfrom
msvc

Conversation

@iphydf
Copy link
Copy Markdown
Member

@iphydf iphydf commented Dec 25, 2023

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Dec 25, 2023
@iphydf iphydf force-pushed the msvc branch 18 times, most recently from f0407b6 to 39d5fb5 Compare December 26, 2023 02:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5cac6d7) 68.96% compared to head (b148a2a) 68.97%.

Files Patch % Lines
toxcore/LAN_discovery.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2498   +/-   ##
=======================================
  Coverage   68.96%   68.97%           
=======================================
  Files          89       89           
  Lines       27782    27787    +5     
=======================================
+ Hits        19160    19166    +6     
+ Misses       8622     8621    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the msvc branch 10 times, most recently from 74344f1 to 1ddc78b Compare December 26, 2023 11:41
@iphydf iphydf force-pushed the msvc branch 8 times, most recently from f1366de to f745fef Compare December 27, 2023 04:26
@iphydf iphydf marked this pull request as ready for review December 27, 2023 04:26
@iphydf iphydf requested a review from a team as a code owner December 27, 2023 04:26
@iphydf iphydf force-pushed the msvc branch 8 times, most recently from b8b1820 to 7f93367 Compare December 27, 2023 23:02
Comment thread CMakeLists.txt
Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt
Comment thread CMakeLists.txt
Comment thread CMakeLists.txt Outdated
Comment thread cmake/Dependencies.cmake Outdated
@iphydf iphydf merged commit b148a2a into master Jan 6, 2024
@iphydf iphydf deleted the msvc branch January 6, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants