chore: Add IMPORTED_TARGET to pkg-config packages. - #2501
Merged
Conversation
Also use `PRIVATE` for `target_link_libraries`. This helps avoid implicit transitive dependencies.
iphydf
marked this pull request as ready for review
December 26, 2023 00:06
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2501 +/- ##
==========================================
- Coverage 69.01% 68.97% -0.05%
==========================================
Files 89 89
Lines 27770 27770
==========================================
- Hits 19166 19153 -13
- Misses 8604 8617 +13 ☔ View full report in Codecov by Sentry. |
Green-Sky
approved these changes
Dec 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also use
PRIVATEfortarget_link_libraries. This helps avoid implicit transitive dependencies.This change is