chore: Use pkg_search_module directly in cmake.#2502
Merged
Conversation
iphydf
force-pushed
the
pkg-search-module
branch
3 times, most recently
from
December 26, 2023 00:50
df58dc8 to
abe47d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2502 +/- ##
==========================================
- Coverage 69.03% 69.01% -0.03%
==========================================
Files 89 89
Lines 27770 27770
==========================================
- Hits 19172 19165 -7
- Misses 8598 8605 +7 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
pkg-search-module
branch
3 times, most recently
from
December 26, 2023 01:12
f07b499 to
47286a1
Compare
The `pkg_use_module` was doing magic we used to use, but no longer need.
iphydf
force-pushed
the
pkg-search-module
branch
from
December 26, 2023 01:14
47286a1 to
766e62b
Compare
iphydf
marked this pull request as ready for review
December 26, 2023 01:18
robinlinden
approved these changes
Dec 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pkg_use_modulewas doing magic we used to use, but no longer need.This change is