cleanup: Upgrade cppcheck, fix some warnings. - #2504
Conversation
iphydf
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2504 +/- ##
==========================================
- Coverage 69.01% 69.00% -0.01%
==========================================
Files 89 89
Lines 27770 27768 -2
==========================================
- Hits 19165 19162 -3
- Misses 8605 8606 +1 ☔ View full report in Codecov by Sentry. |
nurupo
left a comment
nurupo
left a comment
There was a problem hiding this comment.
Reviewed 31 of 31 files at r1, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @iphydf)
other/analysis/run-cppcheck line 31 at r1 (raw file):
CPPCHECK_CXX+=("--suppress=shadowFunction") # False positive in group.c. CPPCHECK_CXX+=("--suppress=AssignmentAddressToInteger")
Instead of suppressing it codebase-wide, maybe add an inline comment to the offending code line telling cppcheck to ignore it?
Also started teaching it about toxcore's alloc/dealloc functions in hopes of it catching some errors (it doesn't seem to be very good at this, but maybe better than nothing?).
iphydf
left a comment
iphydf
left a comment
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @nurupo)
other/analysis/run-cppcheck line 31 at r1 (raw file):
Previously, nurupo wrote…
Instead of suppressing it codebase-wide, maybe add an inline comment to the offending code line telling cppcheck to ignore it?
Good idea, but it didn't work. Updated the comment.
nurupo
left a comment
nurupo
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
3 participants
Also started teaching it about toxcore's alloc/dealloc functions in hopes of it catching some errors (it doesn't seem to be very good at this, but maybe better than nothing?).
This change is