cleanup: Make TCP connection failures a warning instead of error.#2506
Merged
Conversation
iphydf
force-pushed
the
connect-warning
branch
from
0a6673f to
c17f7dd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2506 +/- ##
==========================================
+ Coverage 68.95% 68.97% +0.02%
==========================================
Files 89 89
Lines 27772 27772
==========================================
+ Hits 19149 19157 +8
+ Misses 8623 8615 -8 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
connect-warning
branch
from
c17f7dd to
9e8078b
Compare
It's not really bad, unless all connections fail. This is currently erroring on FreeBSD tests, making them fail needlessly.
iphydf
force-pushed
the
connect-warning
branch
from
9e8078b to
bd930cc
Compare
JFreegman
approved these changes
Dec 27, 2023
JFreegman
left a comment
JFreegman
left a comment
Member
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not really bad, unless all connections fail. This is currently erroring on FreeBSD tests, making them fail needlessly.
This change is