fix: Use QueryPerformanceCounter on windows for monotonic time.#2509
Merged
Conversation
be24579 to
3cc49dd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2509 +/- ##
==========================================
- Coverage 68.99% 68.95% -0.04%
==========================================
Files 89 89
Lines 27772 27774 +2
==========================================
- Hits 19161 19152 -9
- Misses 8611 8622 +11 ☔ View full report in Codecov by Sentry. |
Green-Sky
requested changes
Dec 27, 2023
This fixes time resolution issues and simplifies the code a bit. QPC can in theory jump forward in time, but in practice not by enough to matter in our use case.
Green-Sky
approved these changes
Dec 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes time resolution issues and simplifies the code a bit. QPC can in theory jump forward in time, but in practice not by enough to matter in our use case.
This change is