Skip to content

fix: Use QueryPerformanceCounter on windows for monotonic time.#2509

Merged
toktok-releaser merged 1 commit into
TokTok:masterfrom
iphydf:qpc
Dec 27, 2023
Merged

fix: Use QueryPerformanceCounter on windows for monotonic time.#2509
toktok-releaser merged 1 commit into
TokTok:masterfrom
iphydf:qpc

Conversation

@iphydf
Copy link
Copy Markdown
Member

@iphydf iphydf commented Dec 27, 2023

This fixes time resolution issues and simplifies the code a bit. QPC can in theory jump forward in time, but in practice not by enough to matter in our use case.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Dec 27, 2023
@iphydf iphydf marked this pull request as ready for review December 27, 2023 11:55
@iphydf iphydf force-pushed the qpc branch 2 times, most recently from be24579 to 3cc49dd Compare December 27, 2023 12:04
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1224e65) 68.99% compared to head (82d8265) 68.95%.

Files Patch % Lines
toxcore/mono_time_test.cc 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2509      +/-   ##
==========================================
- Coverage   68.99%   68.95%   -0.04%     
==========================================
  Files          89       89              
  Lines       27772    27774       +2     
==========================================
- Hits        19161    19152       -9     
- Misses       8611     8622      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread toxcore/mono_time.c Outdated
Comment thread toxcore/mono_time_test.cc Outdated
This fixes time resolution issues and simplifies the code a bit. QPC can
in theory jump forward in time, but in practice not by enough to matter
in our use case.
@pull-request-attention pull-request-attention Bot assigned iphydf and unassigned Green-Sky Dec 27, 2023
@toktok-releaser toktok-releaser merged commit 82d8265 into TokTok:master Dec 27, 2023
@iphydf iphydf deleted the qpc branch December 27, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants