chore: Use GPL license with https.#2515
Merged
iphydf merged 1 commit intoTokTok:masterfrom Jan 1, 2024
Merged
Conversation
nurupo
approved these changes
Jan 1, 2024
Member
nurupo
left a comment
There was a problem hiding this comment.
I have diffed the license with https://www.gnu.org/licenses/gpl-3.0.txt and they exactly match.
Cirrus builds fails with:
(02:09:21) ERROR: /src/workspace/c-toxcore/BUILD.bazel:4:8: no such target '//tools:LICENSE.gpl3-https': target 'LICENSE.gpl3-https' not declared in package 'tools' defined by /src/workspace/tools/BUILD.bazel (Tip: use `query "//tools:*"` to see all the targets in that package) and referenced by '//c-toxcore:license_test'
Fix this and it should be good to go.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
This aligns with the new zig-toxcore-c repo. It is a chore, but better than changing the zig-toxcore-c license to not use https.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2515 +/- ##
==========================================
+ Coverage 69.01% 69.03% +0.02%
==========================================
Files 89 89
Lines 27781 27781
==========================================
+ Hits 19174 19180 +6
+ Misses 8607 8601 -6 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns with the new zig-toxcore-c repo. It is a chore, but better than changing the zig-toxcore-c license to not use https.
This change is