refactor: Align group message sending with other send functions.#2519
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2519 +/- ##
==========================================
+ Coverage 68.92% 68.99% +0.06%
==========================================
Files 89 89
Lines 27781 27782 +1
==========================================
+ Hits 19149 19167 +18
+ Misses 8632 8615 -17 ☔ View full report in Codecov by Sentry. |
|
@JFreegman FYI this breaks the unreleased API, so toxic will need an update. |
|
@iphydf the tox-bootstrapd sha256 error annotation is reported twice somehow. Maybe the lifting grep was unnecessary? Or perhaps something else is going on. |
|
No, it's not unnecessary. It's just that it appears twice, and so it is grepped out twice. |
|
Oh, I see. The grep is necessary. After the |
None of the others use out parameters. Also no toxcore function uses out parameters for anything other than arrays and errors. This would be a first, for no good reason.

None of the others use out parameters. Also no toxcore function uses out parameters for anything other than arrays and errors. This would be a first, for no good reason.
This change is