cleanup: Make array params in toxav [] instead of *. - #2521
Merged
Conversation
Similar to the toxcore PR. It's clearer and helps apigen understand what the API means.
iphydf
marked this pull request as ready for review
January 5, 2024 16:40
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2521 +/- ##
==========================================
+ Coverage 68.98% 69.02% +0.03%
==========================================
Files 89 89
Lines 27781 27781
==========================================
+ Hits 19165 19175 +10
+ Misses 8616 8606 -10 ☔ View full report in Codecov by Sentry. |
robinlinden
approved these changes
Jan 5, 2024
robinlinden
left a comment
robinlinden
left a comment
There was a problem hiding this comment.
Excluding deprecated APIs from apigen is a nice touch too. :P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the toxcore PR. It's clearer and helps apigen understand what the API means.
This change is