refactor: packet broadcast functions now return errors#2542
Merged
JFreegman merged 1 commit intoTokTok:masterfrom Jan 11, 2024
Merged
refactor: packet broadcast functions now return errors#2542JFreegman merged 1 commit intoTokTok:masterfrom
JFreegman merged 1 commit intoTokTok:masterfrom
Conversation
JFreegman
added
the
refactor
JFreegman
force-pushed
the
group_broadcast_error
branch
3 times, most recently
from
4085871 to
40cd3e7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2542 +/- ##
=======================================
Coverage 69.08% 69.08%
=======================================
Files 96 96
Lines 28042 28052 +10
=======================================
+ Hits 19372 19381 +9
- Misses 8670 8671 +1 ☔ View full report in Codecov by Sentry. |
JFreegman
force-pushed
the
group_broadcast_error
branch
from
40cd3e7 to
c241ad1
Compare
Green-Sky
requested changes
Jan 11, 2024
Member
Green-Sky
left a comment
Green-Sky
left a comment
There was a problem hiding this comment.
lets be safe and add the api breakage tag
JFreegman
force-pushed
the
group_broadcast_error
branch
from
c241ad1 to
688391e
Compare
We now return an error if our broadcast packets fail to send for every peer in the group
JFreegman
force-pushed
the
group_broadcast_error
branch
from
688391e to
5b9c420
Compare
pull-request-attention
bot
assigned
Green-Sky and
JFreegman and unassigned
JFreegman and
Green-Sky
Green-Sky
approved these changes
Jan 11, 2024
Member
Author
|
Previously, Green-Sky (Erik Scholz) wrote…
Done. |
Member
Author
|
Previously, Green-Sky (Erik Scholz) wrote…
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now return an error if our broadcast packets fail to send for every peer in the group.
This introduces an API change via an additional error case for custom group packets.
This change is