Skip to content

test: Add C++ classes wrapping system interfaces.#2557

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:test-util
Jan 13, 2024
Merged

test: Add C++ classes wrapping system interfaces.#2557
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:test-util

Conversation

@iphydf

@iphydf iphydf commented Jan 13, 2024

Copy link
Copy Markdown
Member

These are more convenient and safer than the manual vtables we have in
the fuzzer support code. We can override individual member functions,
and C++ will take care of correctly casting and offsetting this-pointers
when needed.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 13, 2024
@iphydf iphydf marked this pull request as ready for review January 13, 2024 15:38
@iphydf iphydf force-pushed the test-util branch 5 times, most recently from b08da4d to b046931 Compare January 13, 2024 16:13
These are more convenient and safer than the manual vtables we have in
the fuzzer support code. We can override individual member functions,
and C++ will take care of correctly casting and offsetting this-pointers
when needed.
@codecov

codecov Bot commented Jan 13, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (4cea4f9) 71.34% compared to head (bcb6592) 71.20%.

Files Patch % Lines
toxcore/network_test_util.cc 3.57% 27 Missing ⚠️
toxcore/test_util.hh 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2557      +/-   ##
==========================================
- Coverage   71.34%   71.20%   -0.15%     
==========================================
  Files         120      127       +7     
  Lines       28393    28514     +121     
==========================================
+ Hits        20257    20302      +45     
- Misses       8136     8212      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf merged commit bcb6592 into TokTok:master Jan 13, 2024
@iphydf iphydf deleted the test-util branch January 13, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants