Skip to content

cleanup: Move the 2-element array pack out of individual events.#2564

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:array-pack-2
Jan 15, 2024
Merged

cleanup: Move the 2-element array pack out of individual events.#2564
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:array-pack-2

Conversation

@iphydf

@iphydf iphydf commented Jan 15, 2024

Copy link
Copy Markdown
Member

It's common across all events. No need to repeat it.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 15, 2024
@iphydf iphydf marked this pull request as ready for review January 15, 2024 17:44
It's common across all events. No need to repeat it.

Co-authored-by: Green Sky <green@g-s.xyz>
@codecov

codecov Bot commented Jan 15, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (687af81) 66.83% compared to head (6caa7ce) 66.92%.

Files Patch % Lines
toxcore/events/file_recv.c 0.00% 1 Missing ⚠️
toxcore/events/group_custom_packet.c 0.00% 1 Missing ⚠️
toxcore/events/group_custom_private_packet.c 0.00% 1 Missing ⚠️
toxcore/events/group_invite.c 0.00% 1 Missing ⚠️
toxcore/events/group_message.c 0.00% 1 Missing ⚠️
toxcore/events/group_moderation.c 0.00% 1 Missing ⚠️
toxcore/events/group_peer_exit.c 0.00% 1 Missing ⚠️
toxcore/events/group_peer_name.c 0.00% 1 Missing ⚠️
toxcore/events/group_peer_status.c 0.00% 1 Missing ⚠️
toxcore/events/group_private_message.c 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2564      +/-   ##
==========================================
+ Coverage   66.83%   66.92%   +0.08%     
==========================================
  Files         146      146              
  Lines       30279    30203      -76     
==========================================
- Hits        20238    20213      -25     
+ Misses      10041     9990      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf merged commit 6caa7ce into TokTok:master Jan 15, 2024
@iphydf iphydf deleted the array-pack-2 branch January 15, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants