Skip to content

refactor: Factor out union pack switch from event packer.#2565

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:union-pack-switch
Jan 15, 2024
Merged

refactor: Factor out union pack switch from event packer.#2565
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:union-pack-switch

Conversation

@iphydf

@iphydf iphydf commented Jan 15, 2024

Copy link
Copy Markdown
Member

Preparation for it being generated.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 15, 2024
@iphydf iphydf force-pushed the union-pack-switch branch 2 times, most recently from 6520880 to ef0cd2c Compare January 15, 2024 17:52
@codecov

codecov Bot commented Jan 15, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (6caa7ce) 66.92% compared to head (afc4724) 66.98%.

Files Patch % Lines
toxcore/tox_event.c 57.77% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2565      +/-   ##
==========================================
+ Coverage   66.92%   66.98%   +0.06%     
==========================================
  Files         146      146              
  Lines       30203    30205       +2     
==========================================
+ Hits        20213    20233      +20     
+ Misses       9990     9972      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf marked this pull request as ready for review January 15, 2024 18:07
@iphydf iphydf force-pushed the union-pack-switch branch from ef0cd2c to 59ba283 Compare January 15, 2024 19:19
@iphydf iphydf force-pushed the union-pack-switch branch from 59ba283 to afc4724 Compare January 15, 2024 19:21
@iphydf iphydf merged commit afc4724 into TokTok:master Jan 15, 2024
@iphydf iphydf deleted the union-pack-switch branch January 15, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants