feat: Add dht_get_nodes_response event to the events system.#2568
Merged
Conversation
iphydf
force-pushed
the
dht-nodes-event
branch
3 times, most recently
from
008ac7e to
d4aa455
Compare
iphydf
force-pushed
the
dht-nodes-event
branch
from
d4aa455 to
5ccd0e4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2568 +/- ##
==========================================
+ Coverage 66.90% 66.91% +0.01%
==========================================
Files 147 148 +1
Lines 30177 30281 +104
==========================================
+ Hits 20190 20264 +74
- Misses 9987 10017 +30 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
dht-nodes-event
branch
3 times, most recently
from
825c042 to
5b1f107
Compare
robinlinden
approved these changes
Jan 16, 2024
Should probably rename it to something starting with `debug_` and make it opt-in. Right now, it absolutely spams the events object.
iphydf
force-pushed
the
dht-nodes-event
branch
from
5b1f107 to
16809dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should probably rename it to something starting with
debug_and make it opt-in. Right now, it absolutely spams the events object.This change is