cleanup: Remove bin_pack_{new,free}.#2572
Merged
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2572 +/- ##
==========================================
- Coverage 66.96% 66.94% -0.03%
==========================================
Files 148 148
Lines 30275 30261 -14
==========================================
- Hits 20275 20257 -18
- Misses 10000 10004 +4 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
bracket-only
branch
4 times, most recently
from
d8eba15 to
a950417
Compare
JFreegman
approved these changes
Jan 16, 2024
JFreegman
left a comment
JFreegman
left a comment
Member
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
iphydf
force-pushed
the
bracket-only
branch
3 times, most recently
from
de4cbb6 to
8109291
Compare
We should only ever use `bin_pack_obj` and friends, which stack-allocate the packer and pass it to callbacks.
Member
|
Interesting, so instead of alloc, call, dealloc, we just pass a callback into a function that does stack allocation and does the call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should only ever use
bin_pack_objand friends, which stack-allocate the packer and pass it to callbacks.This change is