cleanup: make some improvements to group moderation test#2576
Merged
Conversation
JFreegman
added
the
cleanup
- We no longer assert peer roles in the mod event callback because this causes an issue with the new events implementation, which triggers the events after all the packets from the current tox_iterate() are processed, rather than as the packets are received. These checks were superfluous and shouldn't reduce code coverage. - A moderator now sets the topic before the founder kicks him in order to increase internal code coverage.
JFreegman
force-pushed
the
group_mod_test_fixes
branch
from
8b7976a to
5e2c8ca
Compare
iphydf
approved these changes
Jan 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2576 +/- ##
==========================================
- Coverage 66.93% 66.90% -0.03%
==========================================
Files 148 148
Lines 30261 30262 +1
==========================================
- Hits 20254 20247 -7
- Misses 10007 10015 +8 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is