refactor: Add common msgpack array packer with callback.#2577
Merged
iphydf merged 1 commit intoTokTok:masterfrom Jan 18, 2024
Merged
refactor: Add common msgpack array packer with callback.#2577iphydf merged 1 commit intoTokTok:masterfrom
iphydf merged 1 commit intoTokTok:masterfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2577 +/- ##
==========================================
- Coverage 66.85% 66.80% -0.05%
==========================================
Files 148 148
Lines 30330 30376 +46
==========================================
+ Hits 20276 20294 +18
- Misses 10054 10082 +28 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
obj-array
branch
5 times, most recently
from
bb4f824 to
ee8615b
Compare
Green-Sky
reviewed
Jan 18, 2024
Member
Green-Sky
left a comment
Green-Sky
left a comment
There was a problem hiding this comment.
update friend_request event, then this looks good to merge.
iphydf
force-pushed
the
obj-array
branch
2 times, most recently
from
f7df28d to
d595e18
Compare
Green-Sky
approved these changes
Jan 18, 2024
There will be more object arrays that need to be packed. This function takes care of NULL (creating an empty array), and putting the correct array size and calling the per-element callback the right amount of times.
JFreegman
reviewed
Jan 18, 2024
Member
JFreegman
left a comment
JFreegman
left a comment
There was a problem hiding this comment.
Reviewed 42 of 44 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There will be more object arrays that need to be packed. This function
takes care of NULL (creating an empty array), and putting the correct
array size and calling the per-element callback the right amount of
times.
This change is