Skip to content

refactor: Allow NULL pointers for byte arrays in events. - #2578

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:nullable-data
Jan 17, 2024
Merged

refactor: Allow NULL pointers for byte arrays in events.#2578
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:nullable-data

Conversation

@iphydf

@iphydf iphydf commented Jan 16, 2024

Copy link
Copy Markdown
Member

Some events, notably the file chunk recv one, can give NULL pointers to the client. Not sure they should, but that's what happens, so we support it.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 16, 2024
@iphydf
iphydf marked this pull request as ready for review January 16, 2024 23:33
@codecov

codecov Bot commented Jan 16, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 63 lines in your changes are missing coverage. Please review.

Comparison is base (5e2c8ca) 66.90% compared to head (b96e1bd) 66.78%.

❗ Current head b96e1bd differs from pull request most recent head e7fb91d. Consider uploading reports for the commit e7fb91d to get more accurate results

Files Patch % Lines
toxcore/events/group_invite.c 0.00% 6 Missing ⚠️
toxcore/events/group_peer_exit.c 0.00% 6 Missing ⚠️
toxcore/events/conference_invite.c 0.00% 3 Missing ⚠️
toxcore/events/conference_message.c 0.00% 3 Missing ⚠️
toxcore/events/conference_peer_name.c 0.00% 3 Missing ⚠️
toxcore/events/conference_title.c 0.00% 3 Missing ⚠️
toxcore/events/file_recv.c 0.00% 3 Missing ⚠️
toxcore/events/file_recv_chunk.c 0.00% 3 Missing ⚠️
toxcore/events/friend_lossless_packet.c 0.00% 3 Missing ⚠️
toxcore/events/friend_lossy_packet.c 0.00% 3 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2578      +/-   ##
==========================================
- Coverage   66.90%   66.78%   -0.13%     
==========================================
  Files         148      148              
  Lines       30262    30328      +66     
==========================================
+ Hits        20247    20254       +7     
- Misses      10015    10074      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Some events, notably the file chunk recv one, can give NULL pointers to
the client. Not sure they should, but that's what happens, so we support
it.
@iphydf
iphydf merged commit e7fb91d into TokTok:master Jan 17, 2024
@iphydf
iphydf deleted the nullable-data branch January 17, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants