cleanup: Add comment after every #endif.#2587
Conversation
JFreegman
left a comment
JFreegman
left a comment
There was a problem hiding this comment.
Reviewed 73 of 73 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
iphydf
force-pushed
the
endif
branch
2 times, most recently
from
a1ba56d to
43f4a0f
Compare
nurupo
left a comment
nurupo
left a comment
There was a problem hiding this comment.
Reviewed 73 of 73 files at r1.
Reviewable status:
nurupo
left a comment
nurupo
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
toxcore/network.c line 44 at r3 (raw file):
// Comment line here to avoid reordering by source code formatters. #include <libc.h> #endif
What happened here?
iphydf
left a comment
iphydf
left a comment
There was a problem hiding this comment.
Reviewable status:
toxcore/network.c line 44 at r3 (raw file):
Previously, nurupo wrote…
What happened here?
Deleted. But, since you asked, I've made a separate PR for it: #2588.
iphydf
force-pushed
the
endif
branch
3 times, most recently
from
dbf33db to
62a5ed7
Compare
nurupo
left a comment
nurupo
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status:
iphydf
force-pushed
the
endif
branch
4 times, most recently
from
38c99e8 to
47dca28
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2587 +/- ##
==========================================
+ Coverage 71.76% 73.64% +1.87%
==========================================
Files 148 148
Lines 30376 30315 -61
==========================================
+ Hits 21799 22325 +526
+ Misses 8577 7990 -587 ☔ View full report in Codecov by Sentry. |
This makes far-away endifs clearer, so we're applying the rule to all endifs to be consistent.
3 participants
This makes far-away endifs clearer, so we're applying the rule to all endifs to be consistent.
This change is