Skip to content

cleanup: Expand the Tox_Options accessor macros.#2591

Merged
toktok-releaser merged 1 commit into
TokTok:masterfrom
iphydf:tox-options
Jan 24, 2024
Merged

cleanup: Expand the Tox_Options accessor macros.#2591
toktok-releaser merged 1 commit into
TokTok:masterfrom
iphydf:tox-options

Conversation

@iphydf

@iphydf iphydf commented Jan 24, 2024

Copy link
Copy Markdown
Member

Macros should be avoided as much as possible.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 24, 2024
@codecov

codecov Bot commented Jan 24, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (14a1a0b) 73.63% compared to head (6370d0f) 73.68%.

Files Patch % Lines
toxcore/tox_api.c 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2591      +/-   ##
==========================================
+ Coverage   73.63%   73.68%   +0.05%     
==========================================
  Files         148      148              
  Lines       30315    30342      +27     
==========================================
+ Hits        22321    22357      +36     
+ Misses       7994     7985       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Macros should be avoided as much as possible.
@toktok-releaser toktok-releaser merged commit 6370d0f into TokTok:master Jan 24, 2024
@iphydf iphydf deleted the tox-options branch January 24, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants