cleanup: Remove all uses of SIZEOF_VLA.#2592
Merged
iphydf merged 1 commit intoTokTok:masterfrom Jan 25, 2024
Merged
Conversation
iphydf
force-pushed
the
vla-size
branch
3 times, most recently
from
29fba89 to
933f3f7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2592 +/- ##
==========================================
+ Coverage 73.70% 73.72% +0.02%
==========================================
Files 148 148
Lines 30339 30373 +34
==========================================
+ Hits 22361 22394 +33
- Misses 7978 7979 +1 ☔ View full report in Codecov by Sentry. |
nurupo
approved these changes
Jan 25, 2024
Member
nurupo
left a comment
nurupo
left a comment
There was a problem hiding this comment.
Reviewed 12 of 19 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
This is step 1 towards removing VLAs altogether.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is step 1 towards removing VLAs altogether.
This change is