Skip to content

refactor: Rename system_{memory,...} to os_{memory,...}. - #2598

Merged
toktok-releaser merged 1 commit into
TokTok:masterfrom
iphydf:os-sys
Jan 25, 2024
Merged

refactor: Rename system_{memory,...} to os_{memory,...}.#2598
toktok-releaser merged 1 commit into
TokTok:masterfrom
iphydf:os-sys

Conversation

@iphydf

@iphydf iphydf commented Jan 25, 2024

Copy link
Copy Markdown
Member

This rename happens in the system PR, so I'm pulling it out to reduce the size of that PR.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 25, 2024
@iphydf
iphydf marked this pull request as ready for review January 25, 2024 12:57
@codecov

codecov Bot commented Jan 25, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (203e1af) 73.66% compared to head (bdf460a) 73.76%.

Files Patch % Lines
toxcore/network.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2598      +/-   ##
==========================================
+ Coverage   73.66%   73.76%   +0.10%     
==========================================
  Files         148      148              
  Lines       30373    30373              
==========================================
+ Hits        22374    22405      +31     
+ Misses       7999     7968      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JFreegman JFreegman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 33 of 33 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

This rename happens in the system PR, so I'm pulling it out to reduce
the size of that PR.
@iphydf iphydf changed the title refactor: Rename system_{memory,...} to os_{memory,...}. refactor: Rename system_{memory,...} to os_{memory,...} Jan 25, 2024
@iphydf iphydf changed the title refactor: Rename system_{memory,...} to os_{memory,...} refactor: Rename system_{memory,...} to os_{memory,...}. Jan 25, 2024
@toktok-releaser
toktok-releaser merged commit bdf460a into TokTok:master Jan 25, 2024
@iphydf
iphydf deleted the os-sys branch January 25, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants