fix: a few off by one errors in group autotests#2601
Merged
toktok-releaser merged 1 commit intoTokTok:masterfrom Jan 25, 2024
Merged
fix: a few off by one errors in group autotests#2601toktok-releaser merged 1 commit intoTokTok:masterfrom
toktok-releaser merged 1 commit intoTokTok:masterfrom
Conversation
Since we're nul terminating these buffers they need one extra byte
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2601 +/- ##
==========================================
- Coverage 73.72% 73.66% -0.07%
==========================================
Files 148 148
Lines 30373 30373
==========================================
- Hits 22394 22374 -20
- Misses 7979 7999 +20 ☔ View full report in Codecov by Sentry. |
nurupo
reviewed
Jan 25, 2024
Member
nurupo
left a comment
nurupo
left a comment
There was a problem hiding this comment.
Why are we null-terminating them?
nurupo
approved these changes
Jan 25, 2024
Member
nurupo
left a comment
nurupo
left a comment
There was a problem hiding this comment.
Well, I guess it's fine sine these are tests.
Member
Author
So you can print them for debugging/progress messages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're nul terminating these buffers they need one extra byte
This change is