Skip to content

cleanup: Use Bazel modules to enforce proper #include hygiene.#2614

Merged
toktok-releaser merged 1 commit into
TokTok:masterfrom
iphydf:modules
Jan 31, 2024
Merged

cleanup: Use Bazel modules to enforce proper #include hygiene.#2614
toktok-releaser merged 1 commit into
TokTok:masterfrom
iphydf:modules

Conversation

@iphydf

@iphydf iphydf commented Jan 30, 2024

Copy link
Copy Markdown
Member

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 30, 2024
@nurupo

nurupo commented Jan 30, 2024

Copy link
Copy Markdown
Member

"cleanup: Use Bazel modules to enforce proper #include hygiene"?

@codecov

codecov Bot commented Jan 30, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1710a0d) 73.61% compared to head (511bfe3) 73.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2614      +/-   ##
==========================================
+ Coverage   73.61%   73.67%   +0.05%     
==========================================
  Files         148      148              
  Lines       30407    30407              
==========================================
+ Hits        22385    22401      +16     
+ Misses       8022     8006      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the modules branch 2 times, most recently from 990dd17 to 2f18bc2 Compare January 30, 2024 23:11
@iphydf iphydf changed the title cleanup: Use C++ modules to enforce proper #include hygiene. cleanup: Use Bazel modules to enforce proper #include hygiene. Jan 30, 2024
@iphydf

iphydf commented Jan 30, 2024

Copy link
Copy Markdown
Member Author

If people are so confused about -fimplicit-module-maps and -fmodule-map-file, then ok. I've renamed the PR even though it's not using anything from bazel, it only uses the BUILD file for information on how to structure the modulemap.

@toktok-releaser toktok-releaser merged commit 511bfe3 into TokTok:master Jan 31, 2024
@iphydf iphydf deleted the modules branch January 31, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants